jscheffl commented on PR #61636:
URL: https://github.com/apache/airflow/pull/61636#issuecomment-3867154313

   > > Mhm, I am not so for this.
   > > Can you give a reason why a periodic restart is needed? Is there a 
memory leak in the software? Then we should rather fix the root cause and not 
compensate with a preriodic restart feature.
   > 
   > Thanks for your feedback!! This isn’t meant to mask a known memory leak. I 
think the motivation is operational parity: gunicorn provides a built-in 
rolling worker refresh, but the default uvicorn does not. Many users running 
uvicorn on Kubernetes already schedule periodic rollouts externally to keep 
long‑running API server processes fresh. It’s opt‑in and off by default. IMO, 
Users who want built‑in rolling restarts should prefer gunicorn; this option is 
for those who stay on uvicorn. FYI, [#60940 
(comment)](https://github.com/apache/airflow/pull/60940#discussion_r2753284864)
   
   Mhm, still not fully convincing. This adds really a lot of complexity for a 
operational shortcoming that in my view should be fixed in other places.
   
   We are planning to carve-out complexity of the chart and this here adds a 
whole lot of additional complexity. Maybe this is one of the first candidates 
where we offer a structure to add custom stuff on top via Kustomize?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to