shahar1 opened a new pull request, #61713:
URL: https://github.com/apache/airflow/pull/61713
Use AST analysis to ensure `tests_common` (a dev-only package) is not
imported in production source files (`airflow-core`, `providers`, etc.) except
under `TYPE_CHECKING` guards.
This prevents runtime `ModuleNotFoundError` regressions like #61673, where
test utilities are available in CI but missing in production images and PyPI
installs.
**Details:**
- Adds `scripts/ci/prek/check_tests_common_imports_in_src.py`
- Registers the hook in `.pre-commit-config.yaml` for:
- `airflow-core/src/`
- `airflow-ctl/src/`
- `providers/*/src/`
- `task-sdk/src/`
- `shared/*/src/`
This hook will fail if any production file imports `tests_common` at runtime.
---
##### Was generative AI tooling used to co-author this PR?
- [x] Yes (please specify the tool below)
Generated-by: GitHub Copilot following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
