amoghrajesh opened a new pull request, #61728: URL: https://github.com/apache/airflow/pull/61728
<!-- Thank you for contributing! Please provide above a brief description of the changes made in this pull request. Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/ Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping (in general) for the review if you do not see reaction for a few days (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: * closes: #ISSUE * related: #ISSUE --> --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [ ] Yes (please specify the tool below) <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> closes: https://github.com/apache/airflow/issues/58529 ## Why? When workers retrieve connections from secrets backends like AWS Secrets Manager that don't include `conn_type`, the `Connection.from_json()` method fails during deserialization with error: ```python TypeError: Connection.__init__() missing 1 required keyword-only argument: 'conn_type' ``` ## What Making `conn_type` optional in task SDK Connection datamodel to restore backward compatibility with Airflow 2 for connections stored in secrets backends without `conn_type`. For example: connections in AWS Secrets Manager (and other external secrets backends) fail to load on workers when `conn_type` field is missing and that breaks compat with Airflow 3 for certain providers. This will later block users migrating from Airflow 2 to Airflow 3 who have hundreds/thousands of secrets stored without conn_type (which worked fine in Airflow 2). ## Solution Make `conn_type` optional in task SDK `Connection` class. Let me explain why this is safe. 1. Secrets backends run only on workers - connections without `conn_type` exist only in worker context, never sent via Execution API 2. The responses that are sent by the API server always has conn_type - connections from database always have conn_type (NOT NULL column), so execution API `ConnectionResponse` doesn't need changes at all (cadwyn migration etc) For testing, I have added one scenario that would break earlier but doesn't anymore. --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
