Abhiii47 commented on code in PR #62176: URL: https://github.com/apache/airflow/pull/62176#discussion_r2831567767
########## airflow-core/tests/unit/models/test_dagrun_optimization.py: ########## @@ -0,0 +1,82 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import unittest +from unittest import mock + +from sqlalchemy.orm import Session + +from airflow.models.dagrun import DagRun +from airflow.models.taskinstance import TaskInstance as TI + + +class TestDagRunOptimization(unittest.TestCase): + def test_get_task_instances_avoids_joinedload(self): Review Comment: You're right ,I missed this. The API endpoint GET /api/v2/.../taskInstances builds its own query directly and doesn't call DagRun.get_task_instances() at all. My PR only benefits the scheduler's internal call path, not the API. The correct fix for #62027 is in api_fastapi/common/db/task_instances.py switching the three joinedload s to selectinload to avoid row multiplication, and adding load_only to limit columns fetched from DagModel and DagBundleModel. I'll update the PR accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
