SameerMesiah97 commented on code in PR #62176: URL: https://github.com/apache/airflow/pull/62176#discussion_r2829824757
########## airflow-core/tests/unit/models/test_dagrun_optimization.py: ########## @@ -0,0 +1,82 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import unittest +from unittest import mock + +from sqlalchemy.orm import Session + +from airflow.models.dagrun import DagRun +from airflow.models.taskinstance import TaskInstance as TI + + +class TestDagRunOptimization(unittest.TestCase): + def test_get_task_instances_avoids_joinedload(self): Review Comment: I believe there are a few issues with these tests: 1) You appeared to have created a new file just for these 2 tests. Why not include any additional tests in the existing suite in models/test_dagrun.py?. I do not think there is a need for a new class either. 2) The tests validate the implementation (i.e. whether `joinedload` is called), but they’re too shallow for a change that affects ORM loading and DB interaction. I think you should use test DB sessions with a focus on preserving the following invariants: * No `DagRun `rows are loaded from the DB when` load_dag_run=False` (new behavior) * `DagRun` rows are loaded when `load_dag_run=True` (current behavior) * Optionally, multi-session safety (e.g. calling from one session while the DagRun instance belongs to another). This is unlikely in practice, but it’s the main area where this implementation could introduce subtle issues. Please look at the existing tests in models/test_dagrun.py for patterns and make sure these tests are consistent with them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
