dstandish commented on PR #61897: URL: https://github.com/apache/airflow/pull/61897#issuecomment-3938020758
> I've changed my mind about this patch. It's simpler and I can see that you've maintained the functionality and the context propagation logic. Love it. > I'm wondering what's going to happen with the spans if the worker or scheduler changes. I don't think it hurts anything. Maybe if you articulate the potential issues I can help clarify or explore. > Can we make the spans for the execution mechanics optional? Yeah, I think this is necessary. There are some different ways to tackle it. One way is to only add the spans conditionally. In this PR I actually do that in one place -- when the scheduler runs update_state for the dag run. The other way is to add filtering / sampling downstream ... I think @nickstenning gave an indication of how this could look in one of his comments. We will need to figure out the best way to do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
