dstandish commented on code in PR #61897:
URL: https://github.com/apache/airflow/pull/61897#discussion_r2835757751
##########
airflow-core/src/airflow/serialization/definitions/dag.py:
##########
@@ -70,6 +71,18 @@
log = structlog.get_logger(__name__)
+def add_dagrun_span(func):
+ @functools.wraps(func)
+ def wrapper(self, *args, **kwargs):
+ tracer = Trace.get_tracer("dagrun")
+ with tracer.start_as_current_span("create_dagrun") as span:
Review Comment:
yeah i'm a bit torn on it just because, platforms like Jaeger and let you
search by attributes which makes them pretty easy to find.
and naming them by operation is helpful once you know you are looking at a
specific task.
and adding the task id / dag id can get very verbose. and even then, you
mgiht have multiple task instances for each task id (task mapping)....
but, i can see that it could be helpful to see task ids when looking at the
trace of a dag run.
also, i see that with honeycomb for example, when visualizing a span, you
can add columns for any attributes present in the trace
<img width="819" height="466" alt="image"
src="https://github.com/user-attachments/assets/608518ac-8745-4061-b7b8-cf37b96b7041";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
