SameerMesiah97 commented on code in PR #62207:
URL: https://github.com/apache/airflow/pull/62207#discussion_r2835749650
##########
providers/google/src/airflow/providers/google/cloud/operators/dataproc.py:
##########
@@ -518,6 +521,9 @@ def _build_cluster_data(self):
if self.cluster_tier:
cluster_data["cluster_tier"] = self.cluster_tier
+
+ if self.cluster_type:
+ cluster_data["cluster_type"] = self.cluster_type
Review Comment:
We validate a lot of other parameters in this generator. Shouldn’t
`cluster_type` and `cluster_tier` be validated too, given the docs define a
fixed set of valid values? This need not be addressed in this PR but this
inconsistency has been surfaced here.
##########
providers/google/docs/index.rst:
##########
@@ -144,7 +144,7 @@ PIP package Version required
``google-cloud-dataflow-client`` ``>=0.8.6``
``google-cloud-dataform`` ``>=0.5.0``
``google-cloud-dataplex`` ``>=2.6.0``
-``google-cloud-dataproc`` ``>=5.21.0``
+``google-cloud-dataproc`` ``>=5.25.0``
Review Comment:
We should be careful about bumping dependencies as method deprecations and
signature changes can be breaking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
