gopidesupavan commented on code in PR #62232: URL: https://github.com/apache/airflow/pull/62232#discussion_r2836721705
########## providers/common/ai/src/airflow/providers/common/ai/datafusion/object_storage_provider.py: ########## @@ -0,0 +1,89 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from datafusion.object_store import AmazonS3, LocalFileSystem + +from airflow.providers.common.ai.datafusion.base import ObjectStorageProvider +from airflow.providers.common.ai.exceptions import ObjectStoreCreationException +from airflow.providers.common.ai.utils.config import ConnectionConfig, StorageType + + +class S3ObjectStorageProvider(ObjectStorageProvider): Review Comment: Yeah we do have few operators that reads data, but here we are planning to use Apache DataFusion as query engine, as its very fast compare to what we have already in the code base and it can read large amount of data with less time.. So here we are registering all those object stores that supports by datafusion. https://datafusion.apache.org/python/autoapi/datafusion/object_store/index.html And few table providers Delta and Iceberg. not yet implemented in this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
