gopidesupavan commented on code in PR #62232: URL: https://github.com/apache/airflow/pull/62232#discussion_r2839730032
########## providers/common/ai/src/airflow/providers/common/ai/datafusion/engine.py: ########## @@ -0,0 +1,102 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from functools import cached_property +from typing import TYPE_CHECKING, Any + +from datafusion import SessionContext + +from airflow.providers.common.ai.datafusion.format_handlers import get_format_handler +from airflow.providers.common.ai.datafusion.object_storage_provider import ObjectStorageProviderFactory +from airflow.providers.common.ai.exceptions import ObjectStoreCreationException, QueryExecutionException +from airflow.providers.common.ai.utils.config import ConnectionConfig, DataSourceConfig +from airflow.utils.log.logging_mixin import LoggingMixin + + +class DataFusionEngine(LoggingMixin): + """Apache DataFusion engine.""" + + def __init__(self): + super().__init__() + # TODO: session context has additional parameters via SessionConfig see what's possible we can use Possible via DataFusionHook ? Review Comment: Yes it could be new provider or may be we move this complete datafusion module to common-io provider , ideally this is dealing with storages and few table providers eg: Delta and Iceberg. so we have to see how ti goes for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
