jscheffl commented on PR #62334: URL: https://github.com/apache/airflow/pull/62334#issuecomment-3947434218
> In the 1.19.0 Helm Chart release (#50218), the liveness/readiness probe config was added for git-sync containers. I'm wondering if we should rewrite the liveness probe to be less generic and use this git-sync liveness service (deprecate old as it would be a breaking change). > > Also, I'm not sure if there is a need for a readiness probe for git-sync, as it is more for services that accept incoming connections rather than nothing. I'd propose less generic and rather basic is sufficient. I have never seen git-sync failing. Any yes, as it is a non-service I think no readiness is needed. There is always the initial sync container, the other is "just" taking over for constant sync. So the second is all "post init/startup". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
