ashb commented on a change in pull request #6792: [AIRFLOW-5930] Use cached-SQL
query building for hot-path queries
URL: https://github.com/apache/airflow/pull/6792#discussion_r357104982
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -1057,30 +1027,34 @@ def _find_executable_task_instances(self,
simple_dag_bag, states, session=None):
TI = models.TaskInstance
DR = models.DagRun
DM = models.DagModel
- ti_query = (
- session
- .query(TI)
- .filter(TI.dag_id.in_(simple_dag_bag.dag_ids))
+ ti_query = BAKED_QUERIES(
+ lambda session: session.query(TI).filter(
+ TI.dag_id.in_(simple_dag_bag.dag_ids)
+ )
.outerjoin(
DR,
and_(DR.dag_id == TI.dag_id, DR.execution_date ==
TI.execution_date)
)
- .filter(or_(DR.run_id == None, # noqa: E711 pylint:
disable=singleton-comparison
- not_(DR.run_id.like(BackfillJob.ID_PREFIX + '%'))))
+ .filter(or_(DR.run_id.is_(None),
+ not_(DR.run_id.like(BackfillJob.ID_PREFIX + '%'))))
Review comment:
I agree, and we should store a "run_type" column or something similar on the
dag run table.
But this is unchanged behaviour.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
