ashb commented on a change in pull request #6792: [AIRFLOW-5930] Use cached-SQL
query building for hot-path queries
URL: https://github.com/apache/airflow/pull/6792#discussion_r357105720
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -798,14 +777,7 @@ def process_file(self, file_path, zombies,
pickle_dags=False, session=None):
dags = self._find_dags_to_process(dagbag.dags.values(), paused_dag_ids)
- # Not using multiprocessing.Queue() since it's no longer a separate
- # process and due to some unusual behavior. (empty() incorrectly
- # returns true as described in https://bugs.python.org/issue23582 )
- ti_keys_to_schedule = []
-
- self._process_dags(dagbag, dags, ti_keys_to_schedule)
-
- for ti_key in ti_keys_to_schedule:
+ for ti_key in self._process_dags(dagbag, dags, session=session):
Review comment:
Yes, again this was deliberate.
We went from TI, to TIKey, and then back to TI when it was used! This stops
an extra DB lookup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
