jkgeyti commented on issue #6062: [AIRFLOW-5445] Reduce the required resources 
for the Kubernetes's sidecar
URL: https://github.com/apache/airflow/pull/6062#issuecomment-565580715
 
 
   That's a valid point, but/and there's a couple of points I'd raise:
   - I haven't checked in detail, but I believe the merged change is 
incompatible with default settings on AWS EKS.
   - This is a regression compared to how Airflow has previously worked. This 
MR breaks support on some clusters, whereas it would work on all clusters 
before.
   - Limiting over-subscription isn't too esoteric, and it's a shame that 
configuring it prevents default installations of Airflow from working, since 
the proposed change isn't configurable.
   - The chosen requests value must be chosen because the sidecar is ensured to 
be able to work correctly and efficiently with that amount of memory, and it 
should therefore be reasonable to expect setting limits to the same as (or 
not-too-much-more than) the requests value.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to