jkgeyti commented on issue #6062: [AIRFLOW-5445] Reduce the required resources 
for the Kubernetes's sidecar
URL: https://github.com/apache/airflow/pull/6062#issuecomment-565594651
 
 
   Clusters can be misconfigured, sure. But I feel there's a difference here, 
where an options is explicitly decided upon by Airflow. If you _didn't_ specify 
the requests and limits, and airflow wouldn't start up, then it's the user's 
"fault". In this case, Airflow isn't working due to Airflow overriding a 
default value.
   
   That said, I feel overriding the limits to something sensible (like 2x the 
requests) is a good course of action. It'll make for saner defaults, the 
sidecar is granted limited resources, it'll never request an unreasonable 
amount of memory, and most importantly, you won't have to revert the PR.
   
   We run Airflow (webserver etc) on k8s in EKS, and use both the k8s executor 
and operator to spawn workers on the same cluster. The setup is just a 
bog-standard collection of k8s deployments, services, ingresses, and service 
accounts.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to