arnoldmr01 commented on code in PR #62259:
URL: https://github.com/apache/airflow/pull/62259#discussion_r2895333290
##########
providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py:
##########
@@ -215,18 +217,38 @@ def __init__(
f"Expected str, datetime.datetime, or None for parameter
'logical_date'. Got {type(logical_date).__name__}"
)
+ self.run_after = run_after
+ if run_after is NOTSET:
+ self.run_after = NOTSET
+ elif run_after is None or isinstance(run_after, (str,
datetime.datetime)):
+ self.run_after = run_after
+ else:
+ raise TypeError(
+ f"Expected str, datetime.datetime, or None for parameter
'run_after'. Got {type(run_after).__name__}"
+ )
+
if fail_when_dag_is_paused and AIRFLOW_V_3_0_PLUS:
raise NotImplementedError("Setting `fail_when_dag_is_paused` not
yet supported for Airflow 3.x")
def execute(self, context: Context):
if self.logical_date is NOTSET:
- # If no logical_date is provided we will set utcnow()
- parsed_logical_date = timezone.utcnow()
+ if self.run_after is not NOTSET:
+ parsed_logical_date = None
+ else:
+ # If no logical_date is provided we will set utcnow()
+ parsed_logical_date = timezone.utcnow()
elif self.logical_date is None or isinstance(self.logical_date,
datetime.datetime):
parsed_logical_date = self.logical_date # type: ignore
elif isinstance(self.logical_date, str):
parsed_logical_date = timezone.parse(self.logical_date)
+ if self.run_after is NOTSET:
+ parsed_run_after = parsed_logical_date
+ elif self.run_after is None or isinstance(self.run_after,
datetime.datetime):
+ parsed_run_after = self.run_after # type: ignore
+ elif isinstance(self.run_after, str):
+ parsed_run_after = timezone.parse(self.run_after)
Review Comment:
Will modify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
