arnoldmr01 commented on code in PR #62259:
URL: https://github.com/apache/airflow/pull/62259#discussion_r2895331318
##########
providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py:
##########
@@ -215,18 +217,38 @@ def __init__(
f"Expected str, datetime.datetime, or None for parameter
'logical_date'. Got {type(logical_date).__name__}"
)
+ self.run_after = run_after
+ if run_after is NOTSET:
+ self.run_after = NOTSET
+ elif run_after is None or isinstance(run_after, (str,
datetime.datetime)):
+ self.run_after = run_after
+ else:
+ raise TypeError(
+ f"Expected str, datetime.datetime, or None for parameter
'run_after'. Got {type(run_after).__name__}"
+ )
Review Comment:
Yas, this part should be extract as a func to handle those same logic. I
will modify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
