dstandish commented on code in PR #62554:
URL: https://github.com/apache/airflow/pull/62554#discussion_r2896467764
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -2328,18 +2092,12 @@ def _update_state(dag: SerializedDAG, dag_run: DagRun):
tags={},
extra_tags={"dag_id": dag.dag_id},
)
- if span.is_recording():
- span.add_event(
- name="schedule_delay",
- attributes={"dag_id": dag.dag_id, "schedule_delay":
str(schedule_delay)},
- )
Review Comment:
so @ashb we're not actually creating spans in the scheduler anymore. so
this is currently a no-op.
and to me this event is of questionable meaning and utility anyway
the detail spans i talked about are specific to task execution. i don't have
a list handy but you have seen a few of the POC runs in honeycomb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
