dstandish commented on code in PR #62554:
URL: https://github.com/apache/airflow/pull/62554#discussion_r2896490775
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -618,15 +617,6 @@ def emit_metrics(self):
extra_tags={"hostname": self.job.hostname},
)
- span = Trace.get_current_span()
- span.set_attributes(
- {
- "trigger host": self.job.hostname,
- "triggers running": len(self.running_triggers),
- "capacity left": capacity_left,
- }
- )
Review Comment:
in the triggerer we only had "debug" spans but those have since been removed
and this is currently a no-op.
we could leave it if you want... doesn't really matter to me
but even when we still had debug spans created, it would only be sending
them to stdout in a local debugging scenario
we need, i think, to come up with a better way for adding optional detail
levels
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
