YoannAbriel opened a new pull request, #63246:
URL: https://github.com/apache/airflow/pull/63246

   ## Problem
   
   `OSSRemoteLogIO.upload()` passes a full OSS URI to `oss_write()`, which 
internally prepends `base_folder` again. This produces malformed keys like 
`prefix/logs/oss://bucket/prefix/logs/dag_id=.../attempt=1.log`, making logs 
unreadable from the Airflow UI.
   
   ## Root Cause
   
   `upload()` joins `self.remote_base` (the full `oss://bucket/prefix` URI) 
with the relative path, then passes the result to `oss_write()`. But 
`oss_write()` already prepends `self.base_folder` (extracted from 
`remote_base`), so the prefix gets doubled.
   
   ## Fix
   
   Pass only the relative path (relative to `base_log_folder`) to `oss_write()` 
instead of the full OSS URI. Added a test to verify both absolute and relative 
input paths produce the correct relative argument to `oss_write()`.
   
   Closes: #63242
   
   <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code
   
   Generated-by: Claude Code following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to