amoghrajesh commented on code in PR #61461:
URL: https://github.com/apache/airflow/pull/61461#discussion_r2911337934
##########
airflow-core/src/airflow/models/deadline_alert.py:
##########
@@ -86,6 +86,8 @@ def matches_definition(self, other: DeadlineAlert) -> bool:
@property
def reference_class(self) ->
type[SerializedReferenceModels.SerializedBaseDeadlineReference]:
"""Return the deserialized reference class."""
+ if "__class_path" in self.reference:
+ return SerializedReferenceModels.SerializedCustomReference
Review Comment:
Good suggestion actually! I attempted to do it using a newly defined:
`is_builtin_reference()` with some `inspect.isclass()` check to handle
non-class attributes safely. Much cleaner than checking for `__class_path`.
Handled it in: 3246a73a9e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
