amoghrajesh commented on code in PR #61461: URL: https://github.com/apache/airflow/pull/61461#discussion_r2916094457
########## airflow-core/src/airflow/serialization/definitions/deadline.py: ########## Review Comment: Current state is duplicated, but simpler? The `get_reference_class` does a simple iterate, find, and return class OR raise ValueError And `is_builtin_class` does a iterate, find, return True/False We could make a change like have `get_reference_class` return None but it could be a breaking change, since callers might expect an exception for missing refs and I am not so sure if its worth the effort? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
