sjyangkevin opened a new pull request, #63463:
URL: https://github.com/apache/airflow/pull/63463
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
* closes: #63408
* related: #63036
### Summary
#### `page.locator('[data-testid="..."]')` → `page.getByTestId("...")`**
`getByTestId` is a semantic, first-class Playwright API for test-id lookups.
It's shorter and communicates intent clearly.
#### `:has-text()` → `getByRole()`**
`:has-text()` is a Playwright-specific CSS pseudo-selector extension rather
than standard CSS and not resilient to structural changes. `getByRole` queries
the accessibility tree, matching how real users and assistive technologies
perceive the element.
#### `:has-text()` → `getByRole().filter()` to capture column header and
avoid time-out due to matching issue, narrow by visible text. The `filter()`
method uses Playwright's internal text matching rather than a CSS `:has-text()`.
#### `filterBar`, `addFilter()`, `:has-text()` button selectors →
`getByRole()`
`getByRole("button", { name: "Filter" })` queries by accessible name, which
is exactly how screen readers identify buttons. For the menu items, the
accessible name is the item's text, so this works directly without a CSS
pseudo-selector.
#### `tableRows`, `locator("tbody tr")` → `locator("tbody").getByRole("row")`
`getByRole("row")` queries by ARIA role rather than HTML tag, making it
resilient to markup changes (e.g., if `<tr>` were ever replaced with a
`role="row" <div>`). Chaining `.locator("tbody")` first scopes the search to
body rows only, excluding the header row.
#### `waitForTableLoad()`, `waitForFunction()` → web-first assertions
#### `beforeAll` polling, `waitForFunction()` → `expect().toPass()`
Same `waitForFunction` anti-pattern. `expect().toPass()` keeps all locator
logic in Playwright's layer (with proper retries and error messages), instead
of dropping into raw DOM manipulation inside a browser-evaluated function.
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes (please specify the tool below)
Generated-by: [Claude Code (claude-opus-4-6)] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
