Miretpl opened a new pull request, #63464:
URL: https://github.com/apache/airflow/pull/63464
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
While checking the chart for unremoved items after #61018, I noticed that we
actually have some missing conditional logic or inconsistent places.
This PR consists of changes in the rendering conditions for various places
in the chart:
1. Render API Server HPA only when Airflow >= 3.0 and api server is enabled
(in addition to the existing condition)
2. Adjust PgBouncer Network Policy KEDA enabled var to Hybrid Executors
3. Render subjects for various components in SCC RoleBinding when enabled
4. Generate Flower secret when Flower is enabled (in addition to the
existing condition)
5. Generate Kerberos Keytab secret when Kerberos is enabled (in addition to
the existing condition)
6. Generate PgBouncer Certificate Secret when PgBouncer is enabled (in
addition to the existing condition)
Additional changes to the above-mentioned are:
1. Removal of airflowVersion in API Server HPA tests
2. Simplification of SCC RoleBinding tests and separation of some per
Airflow 2 and default chart version
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
