jscheffl commented on code in PR #63478:
URL: https://github.com/apache/airflow/pull/63478#discussion_r2927487935
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -295,6 +295,8 @@ def get_conn(self) -> client.ApiClient:
if disable_verify_ssl is True:
_disable_verify_ssl()
+ if self.client_configuration is None:
+ self.client_configuration =
client.Configuration.get_default_copy()
Review Comment:
Can you maybe use the extended constructor of `_TimeoutK8sApiClient` to pass
the bool `disable_verify_ssl`? Then you do not need to adjust client config on
so many places but can centralize this. Less risk for future inconsistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
