antonio-mello-ai commented on code in PR #63478:
URL: https://github.com/apache/airflow/pull/63478#discussion_r2928064345
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -295,6 +295,8 @@ def get_conn(self) -> client.ApiClient:
if disable_verify_ssl is True:
_disable_verify_ssl()
+ if self.client_configuration is None:
+ self.client_configuration =
client.Configuration.get_default_copy()
Review Comment:
Great suggestion — refactored in 83910f3. `_TimeoutK8sApiClient.__init__`
now accepts a `disable_verify_ssl` keyword argument and handles the
`configuration.verify_ssl = False` logic internally (creating a default config
copy if none was passed). All call sites now just forward the flag:
```python
return _TimeoutK8sApiClient(
configuration=self.client_configuration,
disable_verify_ssl=disable_verify_ssl is True,
)
```
138 tests still passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
