SameerMesiah97 commented on code in PR #63035:
URL: https://github.com/apache/airflow/pull/63035#discussion_r2928025684
##########
providers/amazon/src/airflow/providers/amazon/aws/executors/aws_lambda/lambda_executor.py:
##########
@@ -426,12 +482,12 @@ def process_queue(self, queue_url: str):
if task_key:
if return_code == 0:
- self.success(task_key)
+ self.success(task_key) # type: ignore[arg-type]
Review Comment:
I have removed the `type :ignore` in favour of using `cast`. Now, arguably,
it's another way of doing the same thing but `self.success` and `self.fail` are
defined in `BaseExecutor` (which I am not going to touch in this PR) so this
limits what can be done to satisfy typing whilst keeping the code explicit. If
you have an alternative suggestion in mind, I am all ears.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
