SameerMesiah97 commented on PR #63035: URL: https://github.com/apache/airflow/pull/63035#issuecomment-4051506181
@ferruzzi @o-nikolas I have just pushed my latest changes. Here is a brief summary of the last commit: 1. All variable names, method signatures, docstrings and comments have been updated where appropriate. For some sections of the code where there is some ambiguity (such as `try_adopt_task_instances`), I have left the naming as is. Please refer to my comments responding to your feedback. 2. The interaction between strict mypy conventions and the multiple branches needed to support different Airflow versions made explicit typing difficult in a few places. Where possible, I avoided `# type: ignore`, but in some cases using it was the clearest option. 3. You may notice the diff size increased as most of the tests had to be updated to accomodating the changes in variable names and method signatures. Also, while searching for occurrences of "task(s)" to replace with `workload(s)`, I also cleaned up surrounding comments (typos, capitalization, redundant wording, missing punctuation), which further increased the diff size. CI is green now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
