bittoby opened a new pull request, #63562:
URL: https://github.com/apache/airflow/pull/63562

   Improve Playwright test patterns in `plugins.spec.ts` and `PluginsPage.ts` 
to align with [Playwright Best 
Practices](https://playwright.dev/docs/best-practices).
   
   This PR improves test patterns only. It does not change test coverage or 
behavior.
   
   **Changes in `PluginsPage.ts`:**
   - Replace `page.waitForFunction()` with DOM queries with locator-based 
`waitFor()`
   - Expose `nameColumn` and `sourceColumn` as typed `Locator` properties 
instead of methods returning `string[]`
   
   **Changes in `plugins.spec.ts`:**
   - Replace manual assertions on extracted values with web-first assertions 
(`not.toHaveCount()`, `not.toBeEmpty()`, `toHaveCount()`)
   
   related: #63036
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (Claude Code, claude-sonnet-4-6)
   
   Generated-by: Claude Code (claude-sonnet-4-6) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to