jscheffl commented on code in PR #63204:
URL: https://github.com/apache/airflow/pull/63204#discussion_r2936820899
##########
chart/templates/api-server/api-server-deployment.yaml:
##########
@@ -145,7 +145,7 @@ spec:
envFrom: {{- include "custom_airflow_environment_from" . | default
"\n []" | indent 10 }}
env:
{{- include "custom_airflow_environment" . | indent 10 }}
- {{- include "standard_airflow_environment" . | indent 10 }}
+ {{- include "standard_airflow_environment" (merge (dict
"IncludeJwtSecret" false) .) | indent 10 }}
Review Comment:
Yes, this would be clean, agree. @Miretpl do you see this as a blocking
thing or can this be a later cleanup as well? Would be great to have
`"standard_airflow_environment"` without secrets and creating a
`"standard_airflow_environment_with_jwt_secret"` where the onces with JWT is
only drawn in the specific places but in all other references secure by default
w/o repeated boilerplate code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
