haseebmalik18 commented on code in PR #63559:
URL: https://github.com/apache/airflow/pull/63559#discussion_r2944253698
##########
airflow-core/src/airflow/ui/tests/e2e/pages/DagsPage.ts:
##########
@@ -226,7 +236,11 @@ export class DagsPage extends BasePage {
}
await this.page.keyboard.press("Escape");
- await this.page.waitForTimeout(300);
+ await expect(dropdown)
+ .toBeHidden({ timeout: 5000 })
+ .catch(() => {
+ // Some dropdowns close instantly; a timeout here is not a failure.
+ });
Review Comment:
The `.catch()` might not be needed here, I believe `toBeHidden()` passes if
the element doesn't exist in DOM or is not visible. So if the dropdown closes
instantly, the assertion should pass on its own
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
