choo121600 commented on code in PR #63559:
URL: https://github.com/apache/airflow/pull/63559#discussion_r2945133275
##########
airflow-core/src/airflow/ui/tests/e2e/pages/DagsPage.ts:
##########
@@ -226,7 +231,7 @@ export class DagsPage extends BasePage {
}
await this.page.keyboard.press("Escape");
- await this.page.waitForTimeout(300);
+ await expect(dropdown).toBeHidden({ timeout: 5000 });
Review Comment:
`toBeHidden()` is unreliable on WebKit for Chakra UI Select, as the element
remains in the DOM and is still considered visible even when
`data-state="closed"`.
We should assert Chakra's state directly instead:
```
await expect(dropdown).toHaveAttribute("data-state", "closed", { timeout:
5000 });
```
The same change likely applies to selectDropdownOption.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
