joseotaviorf opened a new pull request, #63939:
URL: https://github.com/apache/airflow/pull/63939
* related: #62501
Backports #62501 to 2.x
Backports three targeted fixes to 2.11.2 to address the race condition
reported in #56750, #56541 and #41101, where a dataset-dependent DAG fires with
one or more upstream dataset events missing from consumed_dataset_events.
Root cause: stale `created_at` timestamps in DatasetDagRunQueue caused the
scheduler's event-window query to exclude valid events, yet the presence-based
readiness check still considered the DAG ready to run.
Changes:
- manager.py: replace ON CONFLICT DO NOTHING with ON CONFLICT DO UPDATE
(Postgres) and add a WHERE guard to prevent backwards timestamp drift; pass
explicit created_at=utcnow() on the non-Postgres merge path so existing rows
are always refreshed.
- scheduler_job_runner.py: wrap create_dagrun in `if dataset_events:` to
prevent phantom runs when the event window is empty; scope the DDRQ DELETE to
`created_at <= exec_date` instead of deleting all rows, so events that arrived
during processing are preserved for the next cycle.
- tests/datasets/test_manager.py: add WHERE-guard regression test for the
Postgres upsert path.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (Cursor with Claude Opus 4.6)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
