tysoncung opened a new pull request, #63990:
URL: https://github.com/apache/airflow/pull/63990
## Problem
`task-logs.spec.ts` uses `page.locator('[data-testid="..."]')` instead of
Playwright's built-in `getByTestId()` method, which is the recommended approach
per [Playwright best practices](https://playwright.dev/docs/best-practices).
The spec is also currently in the `testIgnore` list.
## Solution
**Changes in `task-logs.spec.ts`:**
- Replace `page.locator('[data-testid="..."]')` with `page.getByTestId()` (6
occurrences)
- Replace `page.locator('[data-testid^="virtualized-item-"]')` with
`page.getByTestId(/^virtualized-item-/)` regex pattern
**Changes in `playwright.config.ts`:**
- Remove `task-logs.spec.ts` from `testIgnore` list
## Files Changed
- `airflow-core/src/airflow/ui/tests/e2e/specs/task-logs.spec.ts`
- `airflow-core/src/airflow/ui/playwright.config.ts`
## Checklist
- [x] `page.waitForFunction()` with DOM queries → N/A (not present)
- [x] `page.waitForTimeout()` → N/A (not present)
- [x] `waitForLoadState("networkidle")` → N/A (not present)
- [x] Manual assertions → N/A (already uses web-first assertions)
- [x] `page.evaluate()` for DOM manipulation → N/A (not present)
- [x] CSS `:has-text()` → N/A (not present)
- [x] Remove from ignore spec list ✅
Part of #63036
Closes #63964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
