ahilashsasidharan opened a new pull request, #63994:
URL: https://github.com/apache/airflow/pull/63994
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
## Description
This PR adds pydantic validators to the Pools, Connections and Variables
APIs to ensure that multi\_team mode is enabled when team\_name is provided.
This check is missing from these APIs.
## Motivation
In the case of the Pools API (which should apply to other APIs) without this
check as shown in issue #62251 under Test 3 you are able to create a pool when
multi-team is disabled if there is a pre-existing team in the database, and if
you try to add a pool with a non-existent team you will get a 500 error. With
this change you will now get a 422 value error as shown below with a clearer
error.
<img width="2097" height="669" alt="image"
src="https://github.com/user-attachments/assets/5ed6cb12-4c5e-41df-9e55-1da4f396729f";
/>
## Tests
- Added tests under
airflow-core/tests/unit/api_fastapi/core_api/routes/public for each respective
API file to validate the error behaviour when submitting a request with
team\-name and multi\-team mode disabled.
- Fixed failing tests under
airflow-core/tests/unit/api_fastapi/core_api/routes/public in Connections and
Pools test files due to default behaviour of multi\-team mode being disabled in
tests.
related: #62251
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes (Google Antigravity)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
