abhijeets25012-tech commented on PR #64121:
URL: https://github.com/apache/airflow/pull/64121#issuecomment-4117911424
I think there are a couple of issues causing the CI failures here:
1. Backward compatibility:
The change assumes only the Starlette >=1.0 signature
TemplateResponse(request, name, context), but Airflow still supports
>=0.45.0. This will break older versions.
We probably need conditional handling based on Starlette version
instead of forcing a single signature.
2. Context handling:
The original code included "request" inside the context dict.
Removing it might break template rendering depending on how templates
use the request object.
3. Dependency constraint:
Having both:
"starlette>=0.45.0,<1"
"starlette>=1.0.0"
is conflicting and likely incorrect.
Maybe we should:
- First make TemplateResponse usage compatible with both versions
- Then relax the upper bound cleanly
This should also fix the "unhashable type: 'dict'" error seen in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
