abhijeets25012-tech commented on PR #64121:
URL: https://github.com/apache/airflow/pull/64121#issuecomment-4117899495
It looks like the current change assumes only the Starlette 1.0 signature,
but Airflow still supports older versions (>=0.45.0).
This might be causing the CI failures, especially the "unhashable type:
'dict'"
error if the arguments are interpreted incorrectly in older versions.
Would it make sense to make this backward compatible instead?
For example, we could conditionally handle both signatures:
- For older versions:
TemplateResponse(name, context, request=request)
- For >=1.0:
TemplateResponse(request, name, context)
This would allow supporting both versions without forcing an upgrade.
Also, it might be worth checking if any remaining TemplateResponse calls
still pass request inside the context dict, which could also trigger this
error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
