imrichardwu commented on PR #62583: URL: https://github.com/apache/airflow/pull/62583#issuecomment-4118793316
> > @pierrejeambrun — I'd like your opinion on the prune_deadlines change. Originally, it was called session.delete(deadline) to hard delete the row immediately. I changed it to set met = True and keep the row, so the API/UI can filter deadlines by status (active, met, missed). met > > Sorry I might be missing some context, but I don't understand why we need to add 'met' to the deadlines. (missed is missed. Not missed + delay passed = not missed. Not missed + delay has not passed = pending) The met column is driven by the UI spec in https://github.com/apache/airflow/pull/62583#issuecomment-4117502789. The Dag Run page header is supposed to show one of three states: upcoming, missed, or met. Without keeping the row after completion, we can't distinguish "this deadline was met" from "no deadline exists" as both would show nothing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
