pierrejeambrun commented on PR #62583:
URL: https://github.com/apache/airflow/pull/62583#issuecomment-4119812289

   > The met column was added by the UI spec in 
https://github.com/apache/airflow/pull/62583#issuecomment-4117502789. The Dag 
Run page header is supposed to show one of three states: upcoming, missed, or 
met. Without keeping the row after completion, we can't distinguish "this 
deadline was met" from "no deadline exists" as both would show nothing.
   
   I don't think we need that column. If the row is deleted anyway. 'upcoming' 
and 'missed' has the row in the table. And for 'met' we can take the alerts 
from the serialized dag, and if the deadlines table has no entry for it, it was 
deleted = met.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to