pierrejeambrun commented on code in PR #64374:
URL: https://github.com/apache/airflow/pull/64374#discussion_r3022720731
##########
airflow-core/src/airflow/ui/src/layouts/Details/DetailsLayout.tsx:
##########
Review Comment:
This seems unrelated to the feature. Can you remove that diff please.
##########
airflow-core/src/airflow/ui/src/pages/Dag/Header.tsx:
##########
@@ -118,6 +110,18 @@ export const Header = ({
},
];
+ if (!dag?.is_stale) {
+ stats.splice(2, 0, {
+ label: translate("dagDetails.nextRun"),
+ value: Boolean(dag?.next_dagrun_run_after) ? (
+ <DagRunInfo
+ logicalDate={dag?.next_dagrun_logical_date}
+ runAfter={dag?.next_dagrun_run_after as string}
+ />
+ ) : undefined,
+ });
+ }
+
Review Comment:
you can just use the spread operator her to not have to splice.
`...(!dag?.is_stale: [], [])`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
