deepujain commented on PR #64374:
URL: https://github.com/apache/airflow/pull/64374#issuecomment-4172685512
Addressed the review points on this branch:
- removed the unrelated `DetailsLayout.tsx` diff from the PR
- updated the header to hide `ParseDagButton` for stale DAGs
- refactored the stale/non-stale `nextRun` stat assembly to use a spread
instead of `splice`
- updated the PR description so it no longer claims a trigger-button change
that this PR does not implement
I kept the code change scoped to the stale DAG detail/header path from the
original issue report rather than broadening this PR into the DAG list views.
Local validation on this head:
- `npm run test -- Header.test.tsx`
Result: `2 passed` test files / `3 passed` tests
- `pnpm exec eslint src/pages/Dag/Header.tsx src/pages/Dag/Header.test.tsx
src/layouts/Details/DagBreadcrumb.tsx src/layouts/Details/DetailsLayout.tsx
src/components/DagDeactivatedBadge.tsx`
Result: passed
Pushed in `c4c0ebbe13`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
