pierrejeambrun commented on code in PR #63467:
URL: https://github.com/apache/airflow/pull/63467#discussion_r3032887529
##########
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.tsx:
##########
@@ -168,10 +228,13 @@ export const Logs = () => {
};
const logContentProps: TaskLogContentProps = {
+ currentMatchIndex: searchMatchIndices[currentMatchIndex],
Review Comment:
That's confusing. `currentMatchIndex: searchMatchIndices[currentMatchIndex],`
On the left matchIndex is the log line row index. On the right
`curerentMatchIndex` is something else. (the index in the set to get the log
index).
Can you not name them the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
