antonio-mello-ai commented on PR #63467: URL: https://github.com/apache/airflow/pull/63467#issuecomment-4187020945
@pierrejeambrun Thanks for the review! Rebased and addressed both points: 1. **Duplicated code**: Extracted `getTextLines()` into `utils.ts` — single source of truth for the `parseStreamingLogContent` → `renderStructuredLog` pipeline. 2. **Variable naming**: Renamed to `currentMatchLineIndex` (the log line index) vs `currentMatchIndex` (position in the matches array). Ready for another look when you have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
