shashbha14 commented on PR #66593: URL: https://github.com/apache/airflow/pull/66593#issuecomment-4421945459
> Code looks good to me, but I think this would be difficult to reproduce through normal usage, since the invalid JSON has to be inserted directly into the DB. > > @shashbha14 If you still have the reproduction scenario, would you mind sharing it? I think that context could be helpful for reviewers. This can happen in a few real-world scenarios beyond direct DB edits: 1. Connections migrated from older Airflow versions where validation was less strict 2. Connections created via the REST API or CLI without JSON validation 3. Connections imported from external systems or configuration management tools that store extra as a plain string The fix is a defensive guard consistent with what the same file already does at lines 103-110, so even if the scenario is rare it is the correct pattern to follow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
