shashbha14 commented on PR #66593: URL: https://github.com/apache/airflow/pull/66593#issuecomment-4427759627
> Thanks for the detailed context. I might be missing something, but I'm having trouble reproducing this against current main. > > From what I can tell: > > 1. The REST API already rejects invalid JSON in `ConnectionBody.validate_extra`. > 2. airflowctl `connections import/add` go through the same validation path. > 3. `Connection._validate_extra()` raises during `get_extra()`, so even legacy invalid rows should fail before reaching `ConnectionResponse.redact_extra()` > > So if invalid JSON actually made it into the DB, I'd expect the connections API itself to 500 before the Edit dialog receives data. > > That said, I'm still 👍 on merging this as defense-in-depth since the change is tiny and consistent > > If you were able to reproduce the form crash on a 3.x setup, I'd also be very interested in a screenshot or recording? since that would suggest a serializer/API issue beyond this PR alone. Fair point, the validation guards make this hard to trigger in practice. It's just a small safety net matching what's already done at lines 103-110. Happy to go with whatever you decide! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
