Lee-W commented on code in PR #66979:
URL: https://github.com/apache/airflow/pull/66979#discussion_r3246431475
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -611,7 +613,7 @@ def inner(
order_by: list[str] = Query(
default=default_list,
description=f"Attributes to order by, multi criteria sort is
supported. Prefix with `-` for descending order. "
- f"Supported attributes: `{', '.join(all_attrs) if all_attrs
else self.get_primary_key_string()}`",
+ f"Supported attributes: `{', '.join(all_attrs) if all_attrs
else self.get_primary_key_string()}`", # noqa: B008
Review Comment:
If we want to enable it, shouldn't we calculate before inner?
##########
providers/google/src/airflow/providers/google/cloud/transfers/s3_to_gcs.py:
##########
@@ -165,7 +165,7 @@ def __init__(
replace=False,
gzip=False,
google_impersonation_chain: str | Sequence[str] | None = None,
- deferrable=conf.getboolean("operators", "default_deferrable",
fallback=False),
+ deferrable=None,
Review Comment:
it should break our ast checker 🤔 if not, then there's an issue in the
checker. I kinda feel we should leave this deferable thing as it is. otherwise,
the checker logic will be more complicated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
