shahar1 commented on code in PR #66979:
URL: https://github.com/apache/airflow/pull/66979#discussion_r3249515286
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -611,7 +613,7 @@ def inner(
order_by: list[str] = Query(
default=default_list,
description=f"Attributes to order by, multi criteria sort is
supported. Prefix with `-` for descending order. "
- f"Supported attributes: `{', '.join(all_attrs) if all_attrs
else self.get_primary_key_string()}`",
+ f"Supported attributes: `{', '.join(all_attrs) if all_attrs
else self.get_primary_key_string()}`", # noqa: B008
Review Comment:
Fixed in 35adb98 — computed `_order_by_query = Query(...)` before the
`inner` definition and used it as the default directly, removing the `# noqa:
B008` suppression.
---
Drafted-by: Claude Code (claude-sonnet-4-6); reviewed by @shahar1 before
posting
##########
providers/google/src/airflow/providers/google/cloud/transfers/s3_to_gcs.py:
##########
@@ -165,7 +165,7 @@ def __init__(
replace=False,
gzip=False,
google_impersonation_chain: str | Sequence[str] | None = None,
- deferrable=conf.getboolean("operators", "default_deferrable",
fallback=False),
+ deferrable=None,
Review Comment:
Agreed — reverted in 35adb98. The `deferrable=conf.getboolean("operators",
"default_deferrable", fallback=False)` signature is restored (with the type
annotation `deferrable: bool = ...` added so B008 doesn't flag the unannotated
call), and the two tests that assumed `None`-sentinel behaviour are removed.
---
Drafted-by: Claude Code (claude-sonnet-4-6); reviewed by @shahar1 before
posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
