jscheffl commented on code in PR #66970:
URL: https://github.com/apache/airflow/pull/66970#discussion_r3246811426
##########
chart/docs/index.rst:
##########
@@ -190,6 +189,10 @@ This will run database migrations every time there is a
``Sync`` event in Argo C
If you use the ``CeleryExecutor`` with the built-in Redis, it is recommended
that you set up a static Redis password either by supplying
``redis.passwordSecretName`` and ``data.brokerUrlSecretName`` or
``redis.password``.
+.. note::
+
+ Due to security concerts, it is not advised to set sensitive values like
passwords within the ``values.yaml``.
Review Comment:
Typo
```suggestion
Due to security concerns, it is not advised to set sensitive values like
passwords within the ``values.yaml``.
```
##########
chart/docs/upgrading-to-airflow-3.rst:
##########
@@ -97,8 +94,7 @@ for details.
Check the minimum Kubernetes version
------------------------------------
-Chart ``1.17.0`` raised the minimum supported Kubernetes version to ``1.30``.
Upgrade your cluster before upgrading
-the chart if needed.
+Chart ``1.19.0`` supports ``1.30+`` Kubernetes version. Upgrade your cluster
before upgrading the chart if needed.
Review Comment:
Adding Jinja constants here as well?
##########
chart/docs/index.rst:
##########
@@ -62,25 +62,24 @@ deployment on a `Kubernetes <http://kubernetes.io>`__
cluster using the
Requirements
------------
-- Kubernetes 1.30+ cluster
-- Helm 3.10+
-- PV provisioner support in the underlying infrastructure (optionally)
+.. jinja:: global_ctx
+
+ - Kubernetes {{ min_k8s_version }}+ cluster
+ - Helm 3.19+
Review Comment:
Should we make Helm version also a Jinja value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
