ashb commented on code in PR #67070:
URL: https://github.com/apache/airflow/pull/67070#discussion_r3257811120
##########
airflow-core/src/airflow/settings.py:
##########
@@ -140,6 +165,11 @@ def get_session():
return Session
+def block_orm_access():
+ """Block access to the ORM by marking state."""
+ _AirflowSettings.block_orm_access = True
Review Comment:
This has no place in airflow-core
##########
airflow-core/src/airflow/settings.py:
##########
@@ -250,16 +280,16 @@ def _get_async_conn_uri_from_sync(sync_uri):
def configure_vars():
"""Configure Global Variables from airflow.cfg."""
- global SQL_ALCHEMY_CONN
- global SQL_ALCHEMY_CONN_ASYNC
global DAGS_FOLDER
global PLUGINS_FOLDER
- SQL_ALCHEMY_CONN = conf.get("database", "sql_alchemy_conn")
+ _AirflowSettings.sql_alchemy_conn = conf.get("database",
"sql_alchemy_conn")
Review Comment:
Oh look. Global state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
