jscheffl opened a new pull request, #67070:
URL: https://github.com/apache/airflow/pull/67070

   After PR https://github.com/apache/airflow/pull/61917 and the reversion in 
https://github.com/apache/airflow/pull/65718 this is now another round as 
attempt. Thanks to @Miretpl for the hint of the cause. Will run explicitly all 
tests prior merging. CHange to previous is that I'd not propose to backport but 
have this in 3.3.0
   
   ---
   
   Another small increment to remove global statements for PR 
https://github.com/apache/airflow/pull/58116 - an alternative approach to 
#61356.
   
   This removes (some) global statements from settings.py where the a lot of 
state was hold in variables used with global and then a lot of code way relying 
to access these globals. Is a like a public interface and refactoring would be 
needed. 
   
   `global` is evil.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [ ] Yes (please specify the tool below)
   
   <!--
   Generated-by: [Tool Name] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to